Don't repeat default for CMAKE_CXX_FLAGS_DEBUG #7743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7743
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 86606ed with merge base bfccee3 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
swolchok
added a commit
that referenced
this pull request
Jan 17, 2025
Debug build type already has defaults, and the flags we set are likely to be those defaults on Unix-like platforms. Why break Windows compatibility? ghstack-source-id: cb5834ba1b2c6196ef79af8d658077ff0c59fee4 ghstack-comment-id: 2599288517 Pull Request resolved: #7743
facebook-github-bot
added
the
CLA Signed
swolchok
requested review from
dbort,
digantdesai,
malfet and
larryliu0820
and removed request for
dbort and
digantdesai
swolchok
added
the
release notes: build
dbort
approved these changes
Jan 22, 2025
YIWENX14
pushed a commit
that referenced
this pull request
Jan 28, 2025
Debug build type already has defaults, and the flags we set are likely to be those defaults on Unix-like platforms. Why break Windows compatibility?
zonglinpeng
pushed a commit
to zonglinpeng/executorch
that referenced
this pull request
Jan 30, 2025
Debug build type already has defaults, and the flags we set are likely to be those defaults on Unix-like platforms. Why break Windows compatibility?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debug build type already has defaults, and the flags we set are likely to be those defaults on Unix-like platforms. Why break Windows compatibility?